Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce password strength constraint #209

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

Pr0Ger
Copy link
Contributor

@Pr0Ger Pr0Ger commented Sep 14, 2022

We have server-side check for password strength, this PR will add client side validation with same restrictions

@TawR1024
Copy link
Collaborator

@Pr0Ger , is this PR still active ? If it actual, please update it and fix tests, otherwise close it.

@Pr0Ger Pr0Ger marked this pull request as ready for review August 15, 2023 11:29
@Pr0Ger
Copy link
Contributor Author

Pr0Ger commented Aug 18, 2023

@TawR1024 @kolsean Comrades, this PR is ready for your attention

Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@TawR1024 TawR1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kolsean kolsean merged commit 543d885 into master Aug 23, 2023
2 checks passed
@Pr0Ger Pr0Ger deleted the user_password_validation branch August 26, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants